-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interact menu - Convert 'use list menu' setting to 'use wheel menu' #6656
Conversation
I do think |
it's all synonyms, radial sound good too but it might be harder to translate, so I kept it simple |
It doesn't work grammatically in English because wheel is a noun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I don't like this change but oh well... I don't like many things recently.
Is this a real PR or a shitpost? |
That's not very nice pabst, and yes this is a real PR, list are superior to radial, they can display more entries with longer text and are easier to navigate, as such they should be made the default behavior of the interaction menu. |
Let's not change years old defaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR changes default settings and breaks client configured preferences.
I am undecided, if most agree it should not be merged, let's just close it. |
Sorry for my rude comment |
I would've just changed value = 0; to value = 1; |
I would still like to see this changed. |
I am still in favour of this change, and @commy2's comment:
|
I personally think list should be the default, however would just change the default setting value rather than create a new setting for backwards compatibility. |
Replaced by #8217. |
When merged this pull request will:
Lists are superior, can display more elements at once and are easier to read.